Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partners #364

Closed
wants to merge 42 commits into from
Closed

Partners #364

wants to merge 42 commits into from

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jul 16, 2024 •
edited
Loading

closes #351

What this PR does

  • Home page: Add image logos
  • Partners page: Contact template
  • Partners page: Add photos, text, links
  • CSS: Add pulled quote text style
  • CSS: Add statistics text style
  • CSS: Add small attribution text style
  • CSS: All the spacings - Desktop
  • CSS: All the spacings - Mobile
  • Design: Add statistics box rhombus style

Notes

  • This PR changed the names for all the CSS classes/SVG paths with rhombuses - that includes the homepage, Press, Resources and Partners page. So please review all the pages for any regressions (there shouldn't be though!).
  • I'm starting this new thing of having a basic naming convention for images: (name of page)-(type of image)-(slug), like home-logo-calsta or partners-background-cdt. Mobile only images have --sm appended at the end:
image

@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for cal-itp-website ready!

Name Link
🔨 Latest commit 49e25db
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/669f063632fa6900084f7a03
😎 Deploy Preview https://deploy-preview-364--cal-itp-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@machikoyasuda machikoyasuda marked this pull request as ready for review July 17, 2024 22:28
@machikoyasuda machikoyasuda requested review from a team as code owners July 17, 2024 22:28
@machikoyasuda
Copy link
Member Author

machikoyasuda commented Jul 17, 2024 •
edited
Loading

This PR is ready for a code review. The copy is not finalized yet, so I have just used the latest available copy. When the code and the latest copy is available, then this PR can be approved and deployed to a separate Netlify preview page so that the partners can review it easily.

I also filed #365 this because I noticed the blues are different. It is not part of this PR though, as it should be treated separately.

cc @thekaveman @mrose914 @ohmegasquared

@mrose914
Copy link

mrose914 commented Jul 17, 2024 •
edited
Loading

This is looking great, thank you!

CDT messaged today that they are confirming stats as we speak, but that the other copy is GTG.

CARB messaged last week that they are working on getting a quote + we are confirming CARB funding details that may require add'l disclosures.

I will follow up end of this week or early next to nudge them toward finalizing but we seem to be on track! 🙏

@thekaveman
Copy link
Member

I'm starting this new thing of having a basic naming convention for images: (name of page)-(type of image)-(slug), like home-logo-calsta or partners-background-cdt.

💯 💯 💯

@ohmegasquared
Copy link

should we add mobile/web in the image name convention?

@thekaveman
Copy link
Member

@machikoyasuda could you please rebase this PR on main to get the other homepage changes in here, so we can see the final final designs with Partners?

@machikoyasuda
Copy link
Member Author

@thekaveman Rebased and updated partner logos to use the latest (have been updated to have all the same height).

thekaveman
thekaveman previously requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small spacing issues

src/partners.html Show resolved Hide resolved
src/partners.html Show resolved Hide resolved
@thekaveman thekaveman dismissed their stale review July 23, 2024 15:52

Review comments were incorrect.

@machikoyasuda machikoyasuda requested a review from thekaveman July 23, 2024 19:54
@machikoyasuda
Copy link
Member Author

🚧 🚧 🚧
FYI - This pull request is not going to Production. We are still waiting on final copy and approvals.

The "reviews" at this stage for this PR are purely for the design from @ohmegasquared and code from @thekaveman.

🚧 🚧 🚧

@machikoyasuda machikoyasuda self-assigned this Jul 24, 2024
This was referenced Jul 24, 2024
Merged
Merged
Closed
Merged
@machikoyasuda machikoyasuda marked this pull request as draft July 24, 2024 20:49
@machikoyasuda
Copy link
Member Author

Planning to push up a cleaned up version of this PR after the smaller PRs are merged into main.

@machikoyasuda machikoyasuda deleted the feat/351-partners branch July 26, 2024 04:22
This was referenced Jul 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman Awaiting requested review from thekaveman

Assignees

@machikoyasuda machikoyasuda

Labels
None yet
Projects
None yet
Milestone
Customer Stories and Partners
Development

Successfully merging this pull request may close these issues.

Partners page and home copy update
4 participants
@machikoyasuda @mrose914 @thekaveman @ohmegasquared